fix issue related to rendering list tags #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue related to rendering list tags by implementing HTML sanitization to handle the conversion between ordered (<ol>) and unordered (<ul>) list elements based on QuillJS data attributes.
- Adds HTML sanitization functionality to properly handle list tag rendering
- Introduces a new
MudHtmlEditorOptionsclass with sanitization controls - Provides backward compatibility through a deprecated parameter for list tag replacement
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Tizzani.MudBlazor.HtmlEditor.csproj | Bumps version from 2.3.0 to 2.3.1 |
| MudHtmlEditor.razor.js | Adds HTML sanitization methods and options parameter support |
| MudHtmlEditor.razor.cs | Introduces MudHtmlEditorOptions class and deprecated backward compatibility parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
looking forward to this one getting approved. I have struggled with this myself. thank you for fixing this! Eric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(kinda) fixes #28
This is a potential solution for the ol/ul tag issue, but this is a bit of a can of worms (there are many quill-specific CSS classes applied for things like nested lists, alignment, etc.)
This may be something better left for the next full version update. Will think some more on this over the next few days.